Conversation
For unsupported platforms, the host_os variable in the error message was not defined.
While these are approximately 1:1 with the different platforms, it is more appropriate to define them by their interface name so that they can be reused between, for example, multiple platforms that use X11.
Owner
|
Thank you for submitting an interesting feature addition. I've been quite busy lately, so it may take some time before I can start reviewing. If possible, could you provide instructions on how to run OpenGL apps on FreeBSD to verify this PR's functionality? |
Author
|
That is a good thought, I will see what I can do this weekend. My only evidence is 'works for me' :). I will see if I can get the samples going under a VM as well, and maybe will have the opportunity to try (and document) the process with OpenBSD and NetBSD as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for the FreeBSD platform, and perhaps make it slightly easier to support other X11 platforms in the future.
Technically the only change required would have been to trick the library into treating FreeBSD as Linux, however I also took the step to rename the platform specific files into interface specific ones, and then properly added another symbol to represent the new platform and reused the existing X11 specific GLX interface file.
In theory we could do the same for OpenBSD and NetBSD et. al., or even do a generic BSD platform; however, I do not have those platforms to test with and I figured this was a good start.