feat(cc-widgets): Add multi-party conference E2E suites for SET_7 and SET_8

[rsarika]

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7322

This pull request addresses

Missing and uneven multi-party conference E2E coverage for the conference matrix scenarios, where tests were not logically split for parallel execution by set, and conference merge actions could intermittently fail due to missing button readiness checks.

by making the following changes

• Added a shared multi-party conference E2E implementation in playwright/tests/conference-transfer-switch-test.spec.ts.
• Split coverage into two logical suites for parallel runs:
  • SET_7: MPC scenarios (CTS-MPC-01..16)
  • SET_8: Transfer + Switch scenarios (CTS-TC-01..05, CTS-SW-01..05)
• Added suite files under playwright/suites/ following existing structure:
  • conference-mpc-transfer-tests.spec.ts
  • conference-switch-tests.spec.ts
• Updated set mappings in playwright/test-data.ts for SET_7 and SET_8.
• Added conference desktop setup support in playwright/test-manager.ts for 4-agent conference flows.
• Added explicit merge-button readiness validation (visible + enabled) before merge click in conference setup flows.
• Kept out-of-scope cases as expected skip/fixme per agreed scope (TC14, TC20, TC17-19).

The following scenarios were tested

• yarn test:e2e --project=SET_7
• yarn test:e2e --project=SET_8
• yarn test:e2e --project=SET_7 --project=SET_8

Result:

• Combined execution passed with expected skip/fixme cases only.

[aws-amplify-us-east-2]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-624.d1b38q61t1z947.amplifyapp.com

[rsarika]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[akulakum]

PR Review: feat(cc-widgets): Add multi-party conference E2E suites for SET_7 and SET_8

Summary

Good test coverage for multi-party conference scenarios. The PR adds comprehensive E2E tests for MPC, transfer, and switch flows with proper retry patterns and cleanup handling.

Critical Issues (Must Fix)

1. Missing global.setup.ts updates - setupForConferenceDesktop expects AGENT3_ACCESS_TOKEN and AGENT4_ACCESS_TOKEN, but global.setup.ts only handles AGENT1/AGENT2 OAuth flows. SET_7/SET_8 tests will fail at runtime.

2. Missing PAGE_TYPES updates - constants.ts needs AGENT3 and AGENT4 page types for consistency with TestManager changes.

Medium Issues

3. skipOAuth should be environment-driven - Currently hardcoded; should use process.env.PW_SKIP_OAUTH

4. Excessive waitForTimeout usage - ~15+ occurrences of hardcoded waits; prefer explicit condition waits for reliability

5. Helper functions should be extracted - setAgentState, ensureAgentsIdle, submitWrapupIfVisible, clickMergeWhenReady could be reusable utilities in Utils/conferenceUtils.ts

Minor Issues

6. Factory pattern deviation - New parameterized factory differs from existing convention (functional but inconsistent)

7. 5-minute test timeout - Consider per-test timeouts instead of blanket 300s

8. Missing env var validation in getAgentNames()

Documentation Issues

9. Set-to-suite mapping outdated - playwright/ai-docs/AGENTS.md and ai-docs/templates/playwright/00-master.md don't include SET_7/SET_8 mappings

10. Missing setupForConferenceDesktop in TestManager methods list in docs

Positive Observations

✅ Good retry patterns in createInboundAndAccept and consultAgentWithRetry
✅ Proper error handling with .catch(() => {})
✅ Parallel context creation for performance
✅ Explicit merge-button readiness validation (addresses flakiness mentioned in PR description)
✅ Clear test naming convention (CTS-MPC-01, CTS-TC-01, etc.)
✅ Well-structured Playwright template hierarchy in ai-docs/templates/playwright/

[akulakum]

Suggestion: Make skipOAuth environment-driven instead of hardcoded.

const skipOAuth = process.env.PW_SKIP_OAUTH === 'true';

This allows toggling without code changes during local development.

[akulakum]

🔴 Critical: global.setup.ts only handles AGENT1 and AGENT2 OAuth token acquisition. SET_7 and SET_8 define AGENT3 and AGENT4, but there's no corresponding update to global.setup.ts to acquire their tokens.

Tests will fail at runtime with:

Missing required conference access tokens: agent3AccessToken, agent4AccessToken

Please update global.setup.ts to iterate over all agents defined in each USER_SET (not just AGENT1/AGENT2).

[akulakum]

🔴 Critical: PAGE_TYPES in constants.ts is not updated to include AGENT3 and AGENT4. This breaks consistency with the existing page type system.

Please add to constants.ts:

export const PAGE_TYPES = {
  AGENT1: 'agent1',
  AGENT2: 'agent2',
  AGENT3: 'agent3',  // Add
  AGENT4: 'agent4',  // Add
  CALLER: 'caller',
  // ... rest
};

[akulakum]

Clarification needed: The caller page uses agent4AccessToken. The inherited comment on line 73 says "Agent 2 for making calls" which is now misleading for conference flows. Consider updating the comment or documenting why agent4's token is used for the caller in conference scenarios.

[akulakum]

Suggestion: 5-minute timeout is quite long. Consider using per-test timeouts for specific slow tests rather than a blanket timeout for the entire suite.

// Instead of suite-wide:
test.describe.configure({timeout: 300000});

// Consider per-test for slow tests:
test('CTS-MPC-04 should support 4-party conference', async () => {
  test.setTimeout(180000); // 3 min for this specific test
  // ...
});

[akulakum]

Issue: Non-null assertions (!) are used without validation. If env vars are missing, tests fail with unclear errors.

Suggestion: Add validation:

const getAgentNames = () => {
  const agent2Name = process.env[`${testManager.projectName}_AGENT2_NAME`];
  const agent3Name = process.env[`${testManager.projectName}_AGENT3_NAME`];
  
  if (!agent2Name || !agent3Name) {
    throw new Error(`Missing agent name env vars for ${testManager.projectName}`);
  }
  
  return { agent2Name, agent3Name };
};

[akulakum]

Anti-pattern: Hardcoded waitForTimeout calls cause flaky tests. Found ~15+ occurrences in this file.

Suggestion: Replace with explicit condition waits:

// Instead of:
await testManager.callerPage.waitForTimeout(2000);

// Use:
await expect(testManager.callerPage.getByTestId('expected-element')).toBeVisible();
// or
await waitForState(page, expectedState);

This applies to multiple locations in this file (lines 70, 77, 170, etc.).

[akulakum]

Suggestion: These helper functions (setAgentState, ensureAgentsIdle, submitWrapupIfVisible, clickMergeWhenReady, etc.) are generic and reusable.

Consider extracting them to Utils/conferenceUtils.ts for consistency with existing utility patterns and reusability in future conference tests.

// playwright/Utils/conferenceUtils.ts
export async function setAgentState(page: Page, state: string): Promise<void> { ... }
export async function ensureAgentsIdle(pages: Page[]): Promise<void> { ... }
export async function submitWrapupIfVisible(page: Page): Promise<void> { ... }
export async function clickMergeWhenReady(ownerPage: Page): Promise<void> { ... }

[akulakum]

Minor: The afterAll explicitly calls stationLogout for all agents, then calls testManager.cleanup() which also attempts logout. This causes redundant operations.

Suggestion: Either rely on testManager.cleanup() alone:

test.afterAll(async () => {
  await cleanupAllAgents();
  await testManager.cleanup(); // This already handles logout
});

[akulakum]

Note: This parameterized factory pattern differs from existing convention where factories are parameterless:

// Existing pattern:
test.describe('Advanced Task Controls Tests', createAdvancedTaskControlsTests);

// This PR:
test.describe('Conference MPC Tests', () => createConferenceTransferSwitchTests('mpc'));

This is functional but inconsistent with existing patterns. Consider either:

1. Splitting into separate factory files to match existing patterns, OR
2. Documenting this as an intentional evolution for parameterized suites