fix: get_widget could fail with 'x not found in all known widgets'#48
Open
maartenbreddels wants to merge 2 commits intomasterfrom
Open
fix: get_widget could fail with 'x not found in all known widgets'#48maartenbreddels wants to merge 2 commits intomasterfrom
maartenbreddels wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
Fixes widgetti/solara#927 related to #14 #23 |
maartenbreddels
force-pushed
the
fix_get_widget_could_fail
branch
from
d145398 to
ad3f352
Compare
This happened when we could re-render, and there was a function component in the render tree that wouldn't need a re-execution. It would then reconciliate with the old element data (also its arguments) and the reference to the old element would map to get widget that would be used in get_widget. However, a use_effect/use_event would have a reference to a new element and reacton would not be able to find the widget. We now update the args and kwargs of the old element to the new elements.
maartenbreddels
force-pushed
the
fix_get_widget_could_fail
branch
from
b53fa6c to
8d962f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened when we could re-render, and there was a function component in the render tree that wouldn't need a re-execution. It would then reconciliate with the old element data (also its arguments) and the reference to the old element would map to get widget that would be used in get_widget.
However, a use_effect/use_event would have a reference to a new element and reacton would not be able to find the widget.
We now update the args and kwargs of the old element to the new elements.