Open
Conversation
Requires Reference Input instead of Reference Field.
… column whose data type is not a string.
…plied to `ReferenceFieldView`, expected a single ReactElement.
This reverts commit 112e1a5.
KapStorm
suggested changes
Aug 30, 2024
Contributor
There was a problem hiding this comment.
We should create many PR request as many features/bug fixes/etc, if we want to solve 4 issues then we should create 4 separated PR
There are many function that have undesirable empty spaces like:
def Test(): Boolean = {
// <- this type of spaces
1 == 1
// <- this type of spaces
}Please remove them
There are many spaces that are missing between functions, like:
def Temp1(): Unit = {
...
} // <- add space here
def Temp2(): Unit = {
...
}
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Outdated
Show resolved
Hide resolved
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/package.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/DataProvider.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/reactadmin/ImageInput.scala
Show resolved
Hide resolved
KapStorm
suggested changes
Sep 3, 2024
...-server/src/main/scala/net/wiringbits/spra/admin/repositories/DatabaseTablesRepository.scala
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
spra-play-server/src/main/scala/net/wiringbits/spra/admin/utils/QueryBuilder.scala
Outdated
Show resolved
Hide resolved
spra-play-server/src/main/scala/net/wiringbits/spra/admin/models/FieldValue.scala
Outdated
Show resolved
Hide resolved
...ay-server/src/main/scala/net/wiringbits/spra/admin/repositories/daos/DatabaseTablesDAO.scala
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.