Added a Data Provider to manage images#34
Open
Antonio171003 wants to merge 5 commits intowiringbits:mainfrom
Open
Added a Data Provider to manage images#34Antonio171003 wants to merge 5 commits intowiringbits:mainfrom
Antonio171003 wants to merge 5 commits intowiringbits:mainfrom
Conversation
AlexITC
requested changes
Sep 5, 2024
spra-web/src/main/scala/net/wiringbits/spra/ui/web/utils/Images.scala
Outdated
Show resolved
Hide resolved
spra-web/src/main/scala/net/wiringbits/spra/ui/web/utils/Images.scala
Outdated
Show resolved
Hide resolved
AlexITC
requested changes
Sep 7, 2024
|
|
||
| def convertHexToImage(imageHex: String): String = { | ||
| // Check if the argument is a hexadecimal string" | ||
| if (!imageHex.startsWith("\\x") || (imageHex.length % 2) == 1) { |
Contributor
There was a problem hiding this comment.
Why not imageHex.startsWith("0x")?
Contributor
Author
There was a problem hiding this comment.
All hexadecimal strings from the response have the prefix \x.
spra-web/src/main/scala/net/wiringbits/spra/ui/web/utils/Images.scala
Outdated
Show resolved
Hide resolved
… and also added tests for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Data Provider to manage images (saving and reading) to adapt them to the format required for sending to the server.