Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 21, 2026
Merged
paolodamico
reviewed
Jan 25, 2026
Contributor
paolodamico
left a comment
paolodamico
left a comment
There was a problem hiding this comment.
CI must be fixed before merging
| publications { | ||
| create<MavenPublication>("maven") { | ||
| groupId = "org.world" | ||
| artifactId = "walletkit-android" |
Contributor
There was a problem hiding this comment.
Suggested change
| artifactId = "walletkit-android" | |
| artifactId = "walletkit" |
Contributor
Author
There was a problem hiding this comment.
assuming we want this across the board 907d74e
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertNull | ||
|
|
||
| class SimpleTests { |
Contributor
There was a problem hiding this comment.
is this really necessary?
Contributor
Author
There was a problem hiding this comment.
since we don't have any actual kotlin tests in this PR it's useful to verify tests run in the CI. removed in #162
paolodamico
approved these changes
Jan 26, 2026
This was referenced Jan 28, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.