perf: add sync methods to codecs#3721
Merged
d-v-b merged 5 commits intozarr-developers:mainfrom Feb 28, 2026
Merged
Conversation
github-actions
bot
added
the
needs release notes
dcherian
reviewed
Feb 25, 2026
dcherian
approved these changes
Feb 25, 2026
d-v-b
commented
Feb 26, 2026
Comment on lines
+71
to
+73
| def _decode_sync( | ||
| self, chunk_data: NDBuffer | Buffer, chunk_spec: ArraySpec | ||
| ) -> NDBuffer | Buffer: ... |
Contributor
Author
There was a problem hiding this comment.
this reminds me that it makes no sense for our bytes-bytes codecs to take an arrayspec parameter for encoding / decoding. we need to fix that down the road.
d-v-b
force-pushed
the
perf/sync-codec-protocol
branch
from
57886a6 to
2b64daa
Compare
Add comments to clarify memory conversion in encoding.
…zarr-python into perf/sync-codec-protocol
github-actions
bot
removed
the
needs release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds synchronous encode / decode methods to our codecs, and a protocol that models this behavior. These methods will be used in future improvements to the chunk encoding process. Async is a pure performance tax for CPU-limited operations like compression. These methods allow us to avoid that async overhead.
Part of #3720
TODO:
docs/user-guide/*.mdchanges/