define a module for chunk grids, and a registry#3735
Open
d-v-b wants to merge 2 commits intozarr-developers:mainfrom
Open
define a module for chunk grids, and a registry#3735d-v-b wants to merge 2 commits intozarr-developers:mainfrom
d-v-b wants to merge 2 commits intozarr-developers:mainfrom
Conversation
github-actions
bot
added
the
needs release notes
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a modular structure for our chunk grids. Currently we only have the regular chunk grid, but we will get rectilinear chunks soon, and this layout will make that addition much easier.
This PR also adds an explicit registry for chunk grids. Previously we handled chunk grid class lookup in the
ChunkGrid.from_dictmethod. A registry is better, and consistent with the rest of the codebase.Since this is a purely internal change, I don't think we need release notes.