Open
Conversation
Move array_shape from a per-method parameter on ChunkGrid to a stored attribute, validated once at construction time. This simplifies call sites (especially in indexing.py) by eliminating redundant array_shape arguments throughout the codebase. Key changes: - Add abstract `array_shape` property to ChunkGrid ABC - Add `_array_shape` field and `array_shape` property to RegularChunkGrid - Remove `array_shape` parameter from all ChunkGrid abstract methods - Update `from_dict` to accept `array_shape` keyword argument - Update `update_shape` to return a new instance with updated array_shape - Refactor indexing.py to use chunk_grid methods directly instead of raw arithmetic on chunk_shape - Update all construction sites to pass array_shape Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
needs release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
array_shapeattribute toChunkGrid.Depends on #3735, supports #3534
Resolves #3736. Opening as a draft while we figure out the JSON serialization issue.