Allow char ranges in the message_t constructor #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacharle
force-pushed
the
allow-message-t-contruction-from-char-containers
branch
2 times, most recently
from
3ecbe6a to
1bc926e
Compare
Contributor
Author
|
Not sure how to test this more (How to test that the |
cacharle
force-pushed
the
allow-message-t-contruction-from-char-containers
branch
from
1bc926e to
5aae699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to construct a
message_twithstd::vector<char>or other containers with a character as their value type.I assume the condition to disallow this was to avoid conflicts with
std::stringandstd::string_view.