CST-75 znick#379: Add 'edit message' feature#388
Draft
mikhailyumanov wants to merge 13 commits intomasterfrom
Draft
CST-75 znick#379: Add 'edit message' feature#388mikhailyumanov wants to merge 13 commits intomasterfrom
mikhailyumanov wants to merge 13 commits intomasterfrom
Conversation
Edit will be performed in existing id_comment textarea. On submit the form will send information about message edited if any.
znick
requested changes
May 7, 2021
| self.assertTrue(self.s3_storage.exists(file.file.name)) | ||
| self.assertEqual(expected_stdout, out.getvalue().strip()) | ||
|
|
||
| def test_rewrite_url_only_existing_many_refs(self): |
Owner
There was a problem hiding this comment.
Выглядит как будто бы это что-то про S3 :)
Comment on lines
+270
to
+283
|
|
||
| # If event_id in POST, edit message and redirect back | ||
| if 'event_id' in request.POST and request.POST['event_id'].isdigit(): | ||
| user = request.user | ||
| event_id = int(request.POST['event_id']) | ||
| event = get_object_or_404(Event, id=event_id) | ||
| if event.author != user: | ||
| raise PermissionDenied | ||
| event.value = request.POST['comment'] | ||
| event.save() | ||
| print(event.value) | ||
| print(request.POST) | ||
| return HttpResponsePermanentRedirect("/issue/" + request.POST['issue_id']) | ||
|
|
Owner
There was a problem hiding this comment.
Это классно, но нужно все таки сохранять всю историю сообщений.
Owner
|
А тут ведь нет просмотра истории? |
Collaborator
Author
В процессе |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.