-
Notifications
You must be signed in to change notification settings - Fork 467
Review of "Running MaxText at Scale with XPK" guide #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
parambole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on formatting when viewed.
|
I addressed this on the chat, but here's the same message for clarity: Unfortunately, the GitHub markdown parser is quite limited, and some of the functionality we use to create nice formatting and display of text, code and images (as well as anchor linking and reference labels) will not work on plain GitHub. Usually, when projects have a ReadTheDocs site, the primary information delivery method is the generated HTML pages shown on the site, and not the source markdown files on GitHub. If the priority is to have the source files be GitHub-compatible, I will have to remove some of the functionality from the readthedocs pages. I think this is a discussion worth having with the team to make sure we are aligned. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. |
|
This PR was closed because it has been inactive for a while. Please reopen it if you are still working on it. |
4879f0f to
0eb33d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1866aee to
32f4015
Compare
|
This can now be closed as all relevant changes have been applied upstream. Thanks! |
Description
Follow-up to #2238.
This PR mostly fixes some syntax and rendering issues for the "Running MaxText at Scale with XPK" guide. It includes
Tests
The documentation pages were successfully built locally.
Checklist
Before submitting this PR, please make sure (put X in square brackets):