Skip to content

Conversation

@melissawm
Copy link
Collaborator

Description

Follow-up to #2238.

This PR mostly fixes some syntax and rendering issues for the "Running MaxText at Scale with XPK" guide. It includes

Tests

The documentation pages were successfully built locally.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@parambole parambole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on formatting when viewed.

@melissawm
Copy link
Collaborator Author

I addressed this on the chat, but here's the same message for clarity:

Unfortunately, the GitHub markdown parser is quite limited, and some of the functionality we use to create nice formatting and display of text, code and images (as well as anchor linking and reference labels) will not work on plain GitHub. Usually, when projects have a ReadTheDocs site, the primary information delivery method is the generated HTML pages shown on the site, and not the source markdown files on GitHub.

If the priority is to have the source files be GitHub-compatible, I will have to remove some of the functionality from the readthedocs pages. I think this is a discussion worth having with the team to make sure we are aligned.

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Automatically applied to stale PRs. label Nov 12, 2025
@github-actions
Copy link

This PR was closed because it has been inactive for a while. Please reopen it if you are still working on it.

@jacoguzo jacoguzo requested a review from NicoGrande as a code owner November 20, 2025 19:36
@github-actions github-actions bot removed the stale Automatically applied to stale PRs. label Nov 21, 2025
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@melissawm
Copy link
Collaborator Author

This can now be closed as all relevant changes have been applied upstream. Thanks!

@melissawm melissawm closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants