Open
Conversation
- Only throw on non-zero exit code; log stderr as warning otherwise - autorest 3.8.0 emits deprecation message to stderr with exit code 0 - Bump version to 0.12.4 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
raych1
requested review from
danieljurek,
mikeharder,
scbedd and
weshaggard
as code owners
mikeharder
reviewed
Mar 14, 2026
| maxBuffer: 1024 * 1024 * 64, | ||
| env: { ...process.env, NODE_OPTIONS: "--max-old-space-size=8192" } | ||
| }) | ||
| // autorest 3.8.0 emits deprecation message to stderr with exit code 0 |
Member
There was a problem hiding this comment.
I don't think this part of the change is needed at all. If autorest returns nonzero exit, execFile() throws, and we can just let the error bubble up. We don't need to catch and re-throw.
mikeharder
reviewed
Mar 14, 2026
| } | ||
| if (stderr) { | ||
| throw new Error(stderr) | ||
| log.error(`AutoRest completed with warnings on stderr: ${stderr}`) |
Member
There was a problem hiding this comment.
maybe log.debug() would be better than log.error()? autorest writing to stderr isn't really an "error", it's more of a "warning" at best.
mikeharder
requested changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
autorestdependency from ^3.6.1\ to ^3.8.0\