Skip to content

WIP: Multiple accessibility fixes to USE#368

Open
djanelle-mit wants to merge 4 commits intomainfrom
use-accessibility-fixes
Open

WIP: Multiple accessibility fixes to USE#368
djanelle-mit wants to merge 4 commits intomainfrom
use-accessibility-fixes

Conversation

@djanelle-mit
Copy link
Contributor

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@qltysh
Copy link

qltysh bot commented Mar 10, 2026

❌ 2 blocking issues (2 total)

Tool Category Rule Count
rubocop Lint Module has too many lines. [104/100] 1
rubocop Lint Method has too many lines. [14/10] 1

class: 'tab-link',
role: 'button',
data: { turbo_frame: 'search-results', turbo_action: 'advance' }
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [14/10] [rubocop:Metrics/MethodLength]

@coveralls
Copy link

coveralls commented Mar 10, 2026

Pull Request Test Coverage Report for Build 22917894925

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.188%

Totals Coverage Status
Change from base Build 22870113534: 0.0%
Covered Lines: 1355
Relevant Lines: 1380

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-access-o7lrz2 March 10, 2026 18:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants