Skip to content

WIP: Multiple accessibility fixes to USE #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djanelle-mit wants to merge 4 commits into
base: main
Choose a base branch
from
Open

WIP: Multiple accessibility fixes to USE #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f3e439
Added button role to search tabs
djanelle-mit Mar 10, 2026
87d7e32
Removing hidden screen reader title block on USE and GEO
djanelle-mit Mar 10, 2026
551192f
Added hidden SR H2 for suggested resource above TACOS intervention
djanelle-mit Mar 10, 2026
b031d7f
Moved location of H2 for interventions
djanelle-mit Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/helpers/search_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ def link_to_tab(target, label = nil)
link_to tab_label, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
aria: { current: 'page' },
class: 'active tab-link',
role: 'button',
data: { turbo_frame: 'search-results', turbo_action: 'advance' }
else
link_to tab_label, results_path(params.permit(:q, :per_page, :booleanType, :tab).merge(tab: clean_target)),
class: 'tab-link',
role: 'button',
data: { turbo_frame: 'search-results', turbo_action: 'advance' }
end
Copy link

@qltysh qltysh bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [14/10] [rubocop:Metrics/MethodLength]

end
Expand Down
1 change: 0 additions & 1 deletion app/views/search/_result.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<p class="eyebrow"><%= result[:eyebrow] %></p>
<% end %>
<h3 class="record-title">
<span class="sr">Title: </span>
<%= link_to_result(result) %>
</h3>

Expand Down
2 changes: 1 addition & 1 deletion app/views/search/_result_geo.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<li class="result" data-record-id="<%=result_geo[:identifier]%>">
<div class="result-content">
<h3 class="record-title">
<span class="sr">Title: </span><%= link_to(result_geo[:title], record_path(result_geo[:identifier])) %>
<%= link_to(result_geo[:title], record_path(result_geo[:identifier])) %>
</h3>

<div class="data-info">
Expand Down
1 change: 0 additions & 1 deletion app/views/search/_result_primo.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<p class="eyebrow"><%= result[:eyebrow] %></p>
<% end %>
<h3 class="record-title">
<span class="sr">Title: </span>
<% if result[:links]&.find { |link| link['kind'] == 'full record' } %>
<%= link_to(result[:title], result[:links].find { |link| link['kind'] == 'full record' }['url']) %>
<% else %>
Expand Down
1 change: 1 addition & 0 deletions app/views/tacos/analyze.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<% if @suggestions.present? && !Feature.enabled?(:geodata) %>
<div id="hint" aria-live="polite">
<h2 class="sr">Suggested resource</h2>
<aside class="mitlib-suggestion-panel">
<div class="panel-content">
<p class="panel-type">Suggested resource</p>
Expand Down