Open
Conversation
* Removed unnecessary bitmap scaling ops in controller - saves upto 10% CPU. * Removed ineffective album art retry loop in controller. It was ineffective since partial mediadata was never updated in helper. Move logic to media session helper. Highly improves album art rendering chances. * Streamlined playback path. Checks removed in onMediaMetadataChanged() since requestUiUpdate() will necessary update even for media metadata update. * Fetch new album art and icon only if there are changes. * Do pause stale check on chip interaction, media metadata update and playback update - improves UX. * Add padding before compact icon; matches full chip and gives better aesthetics. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.