Conversation
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies clang-format across a set of component headers and an example source file to enforce consistent C++ styling throughout the codebase.
Changes:
- Normalizes brace spacing and line wrapping in constructors/initializer lists.
- Reflows long expressions/comments and standardizes
if (ec) return false;formatting. - Aligns preprocessor directives and includes (e.g.,
#ifdef, header ordering).
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/logger/include/logger.hpp | Minor formatting in move ctor (brace spacing). |
| components/led_strip/include/led_strip.hpp | Wraps long member declarations/expressions; whitespace cleanup in move ops. |
| components/i2c/include/i2c_format_helpers.hpp | Aligns #ifdef/#endif indentation with standard preprocessing style. |
| components/bmi270/include/bmi270_detail.hpp | Reflows struct alignment and ScopeGuard ctor/move-ctor formatting. |
| components/bmi270/include/bmi270.hpp | Large formatting-only reflow: includes, conditionals, lambdas, long expressions, and early-return formatting. |
| components/bmi270/example/main/bmi270_example.cpp | Formatting-only reflow of optional calibration block and whitespace cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.