fix(builtins): use char count instead of byte length in expr#466
Merged
Conversation
expr length now uses chars().count() instead of len() (byte count). expr substr now uses char-based skip/take instead of byte slicing. Prevents panics on multi-byte UTF-8 input. Closes #434 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-434-Y2nIj
branch
from
844ba23 to
d435eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expr lengthusedlen()(byte count) instead ofchars().count()for multi-byte UTF-8expr substrused byte-based slicing instead of char-based iterationTest plan
test_length_multibyte_utf8test_substr_multibyte_utf8Closes #434