Removing the default index.html for new accounts#1276
Merged
jaxoncreed merged 1 commit intomasterfrom Aug 13, 2019
Merged
Conversation
|
I don’t think I agree with this at all! It appears to be in contravention of a pod owner/user capacity to do whatever they want with their homepage root index.HTML, Unless I’m misunderstanding something, it appears you intend to take away the index.HTML in return for some dashboard for the user, is this correct? |
Contributor
Author
|
Answered in #1275 (comment), please continue discussion there. |
jaxoncreed
approved these changes
Jul 23, 2019
Contributor
jaxoncreed
left a comment
jaxoncreed
left a comment
There was a problem hiding this comment.
Thank goodness for this! Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #1275 .
Before releasing this onto production, we need to make sure that we have a functioning dashboard for the data browser. The latest iteration of what will probably come is in SolidOS/solid-panes#131, but we might change that depending on what is ready before first-coming Thursday.