Removing call to logging.basicConfig#124
Open
timmarkhuff wants to merge 1 commit intoquatanium:masterfrom
Open
Removing call to logging.basicConfig#124timmarkhuff wants to merge 1 commit intoquatanium:masterfrom
timmarkhuff wants to merge 1 commit intoquatanium:masterfrom
Conversation
Author
|
@sinchb would you mind reviewing this PR? I think this will improve the logging setup of this library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library makes a call to logging.basicConfig, which should really only be called in applications, not libraries. This causes any logging config that an application attempts to set to be overridden.