Check certFile modification time#2805
Closed
ndtretyak wants to merge 2 commits intotemporalio:mainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
rossnelson
approved these changes
Jul 9, 2025
Collaborator
|
Hey @ndtretyak, could you update your fork to the latest from main and push so CI runs again? The e2e checks are stale. Thanks! |
rossnelson
added a commit
that referenced
this pull request
Feb 24, 2026
The certLoader was using keyFile's modification time to detect certificate changes. When a certificate is renewed using the same key, the keyFile remains unchanged and the new cert is never loaded. This switches to checking certFile's modification time, which correctly detects renewals regardless of whether the key was rotated. Based on #2805 by @ndtretyak.
2 tasks
Collaborator
|
Thanks for this fix @ndtretyak — the analysis is spot-on. Since this has been idle for a bit, I've opened #3178 with the same changes so we can get it merged. Credit to you in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Use the modification time of
certFileinstead ofkeyFile, sincekeyFilemay remain unchanged when the certificate is renewed using the same key.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?