Check certFile modification time instead of keyFile#3178
Open
rossnelson wants to merge 1 commit intomainfrom
Open
Check certFile modification time instead of keyFile#3178rossnelson wants to merge 1 commit intomainfrom
rossnelson wants to merge 1 commit intomainfrom
Conversation
The certLoader was using keyFile's modification time to detect certificate changes. When a certificate is renewed using the same key, the keyFile remains unchanged and the new cert is never loaded. This switches to checking certFile's modification time, which correctly detects renewals regardless of whether the key was rotated. Based on #2805 by @ndtretyak.
rossnelson
requested review from
andrewzamojc
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
laurakwhit
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
certFilemodification time instead ofkeyFilewhen detecting certificate changesBased on #2805 by @ndtretyak.
Test plan