Skip to content

build: don't include UNIX_PROGS for MINGW#11251

Closed
ognevny wants to merge 1 commit intouutils:mainfrom
ognevny:patch-1
Closed

build: don't include UNIX_PROGS for MINGW#11251
ognevny wants to merge 1 commit intouutils:mainfrom
ognevny:patch-1

Conversation

@ognevny
Copy link
Contributor

@ognevny ognevny commented Mar 9, 2026

I'm surely believe that it was committed by mistake

I'm surely believe that it was commited by mistake
@oech3
Copy link
Contributor

oech3 commented Mar 9, 2026

MSYS CI's log said OS=Windows_NT.

@ognevny
Copy link
Contributor Author

ognevny commented Mar 9, 2026

MSYS CI's log said OS=Windows_NT.

MSYS make reports OS as Windows_NT as it should be, that's proper behaviour

@oech3
Copy link
Contributor

oech3 commented Mar 9, 2026

With this change, GnuTests lost UNIX_PROGS. So this looks incorrect.

@oech3
Copy link
Contributor

oech3 commented Mar 9, 2026

MSYS make reports OS as Windows_NT as it should be, that's proper behaviour

Maybe, should we change MINGW to Windows? (since *_NT includes CYGWIN_NT)

@ognevny
Copy link
Contributor Author

ognevny commented Mar 9, 2026

but how do we fix MINGW build then? with this change everything builds correctly for us

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will degrade performance by 3.25%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 297 untouched benchmarks
⏩ 48 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 24.9 ms 25.7 ms -3.25%

Comparing ognevny:patch-1 (89ed3f6) with main (53200b3)

Open in CodSpeed

Footnotes

  1. 48 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants